-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust 1.73.0 #149754
rust 1.73.0 #149754
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
735f604
to
0d3ace9
Compare
0d3ace9
to
25d9086
Compare
Previous run with
CI-build-dependents-from-source
|
12-arm64 still failed, somehow.
|
25d9086
to
6d092f3
Compare
|
I found this warning message
|
rebased after #152284 |
rerun 🤞 |
|
because of caching? I'm not sure 😅 |
can you build and test out fine in your local? |
I have the same problem if I use this commit 1c689ed |
Also, switch to unversioned `llvm` (17). Co-authored-by: Ruoyu Zhong <[email protected]> change rust 1.72.1 to build
1c689ed
to
281e8c2
Compare
okay, let's kick off another run (I am also testing on 12-arm now) |
@junminhong can you use brew gist-logs to upload your local logs if you are using 12-arm for the build? (we only had rust build issue for 12-arm build on CI) |
sorry, I'm using macos 13.5.2 |
Hi folks, |
Close in favor of #154526 |
For what is worth, this PR (rust-lang/rust#117875) actually fixed the build issue on 12-arm |
With 1.74.0 now out, is the team planning on skipping 1.73.0 and just go directly to 1.74.0? |
Yes, we're doing that in #154526. |
for folks on this thread, we have just shipped rust 1.74.0 |
Created by
brew bump
Created with
brew bump-formula-pr
.brew test