Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.73.0 #149754

Closed
wants to merge 1 commit into from
Closed

rust 1.73.0 #149754

wants to merge 1 commit into from

Conversation

junminhong
Copy link
Contributor

@junminhong junminhong commented Oct 6, 2023

Created by brew bump


Created with brew bump-formula-pr.

brew test

截圖 2023-10-11 上午11 36 36

@github-actions github-actions bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing labels Oct 6, 2023
@github-actions

This comment was marked as resolved.

@ZhongRuoyu ZhongRuoyu force-pushed the bump-rust-1.73.0 branch 2 times, most recently from 735f604 to 0d3ace9 Compare October 6, 2023 04:16
@ZhongRuoyu ZhongRuoyu added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 6, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 8, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 10, 2023
6 tasks
@ZhongRuoyu ZhongRuoyu added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Oct 11, 2023
@ZhongRuoyu
Copy link
Member

Previous run with CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. : https://github.com/Homebrew/homebrew-core/actions/runs/6427402091

@ZhongRuoyu
Copy link
Member

12-arm64 still failed, somehow.

  thread 'main' panicked at 'could not read dir "/private/tmp/rust-20231011-5418-uaahrv/rustc-1.73.0-src/build/aarch64-apple-darwin/stage0/lib/rustlib/aarch64-apple-darwin/codegen-backends": Os { code: 2, kind: NotFound, message: "No such file or directory" }', lib.rs:1714:25
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 11, 2023
@ZhongRuoyu ZhongRuoyu added the help wanted Task(s) needing PRs from the community or maintainers label Oct 17, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 19, 2023
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 19, 2023
@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Oct 19, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 20, 2023
@SMillerDev
Copy link
Member

Building stage0 library artifacts (aarch64-apple-darwin)
      Finished release [optimized] target(s) in 0.24s
  thread 'main' panicked at 'could not read dir "/private/tmp/rust-20231019-5370-1ajvakf/rustc-1.73.0-src/build/aarch64-apple-darwin/stage0/lib/rustlib/aarch64-apple-darwin/codegen-backends": Os { code: 2, kind: NotFound, message: "No such file or directory" }', lib.rs:1714:25

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 21, 2023
@chenrui333 chenrui333 added the 12-arm64 Monterey arm64 is specifically affected label Oct 22, 2023
@junminhong
Copy link
Contributor Author

junminhong commented Oct 23, 2023

I found this warning message

Warning: no codegen-backends config matched the requested path to build a codegen backend. Help: add backend to codegen-backends in config.toml.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 23, 2023
@chenrui333
Copy link
Member

rebased after #152284

@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 24, 2023
@chenrui333
Copy link
Member

rerun 🤞

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 24, 2023
@chenrui333
Copy link
Member

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

@junminhong
Copy link
Contributor Author

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

because of caching? I'm not sure 😅
Does anyone know how to solve this problem?

@chenrui333
Copy link
Member

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

because of caching? I'm not sure 😅 Does anyone know how to solve this problem?

can you build and test out fine in your local?

@junminhong
Copy link
Contributor Author

junminhong commented Oct 26, 2023

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

because of caching? I'm not sure 😅 Does anyone know how to solve this problem?

can you build and test out fine in your local?

I have the same problem if I use this commit 1c689ed
But when I commit using da76e67, I can build and test in my local.

Also, switch to unversioned `llvm` (17).

Co-authored-by: Ruoyu Zhong <[email protected]>

change rust 1.72.1 to build
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 26, 2023
@chenrui333
Copy link
Member

okay, let's kick off another run (I am also testing on 12-arm now)

@chenrui333
Copy link
Member

chenrui333 commented Oct 26, 2023

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

because of caching? I'm not sure 😅 Does anyone know how to solve this problem?

can you build and test out fine in your local?

I have the same problem if I use this commit 1c689ed But when I commit using da76e67, I can build and test in my local.

@junminhong can you use brew gist-logs to upload your local logs if you are using 12-arm for the build? (we only had rust build issue for 12-arm build on CI)

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 27, 2023
@junminhong
Copy link
Contributor Author

junminhong commented Oct 27, 2023

  error: failed to select a version for the requirement `serde = "^1.0.171"` (locked to 1.0.188)
  candidate versions found which didn't match: 1.0.171, 1.0.164, 1.0.160, ...
  location searched: directory source `/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/vendor` (which is replacing registry `crates-io`)
  required by package `cargo-platform v0.1.4 (/private/tmp/rust-20231024-5920-vmoiy9/rustc-1.73.0-src/src/tools/cargo/crates/cargo-platform)`
  perhaps a crate was updated and forgotten to be re-vendored?

because of caching? I'm not sure 😅 Does anyone know how to solve this problem?

can you build and test out fine in your local?

I have the same problem if I use this commit 1c689ed But when I commit using da76e67, I can build and test in my local.

@junminhong can you use brew gist-logs to upload your local logs if you are using 12-arm for the build? (we only had rust build issue for 12-arm build on CI)

sorry, I'm using macos 13.5.2
I don't have a macOS 12 device for testing 😭

@jqnatividad
Copy link
Contributor

Hi folks,
Not sure if this is relevant, but putting it here just the same...

rust-lang/rust#116397

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Oct 27, 2023
This was referenced Nov 12, 2023
@chenrui333
Copy link
Member

chenrui333 commented Nov 16, 2023

Close in favor of #154526

@chenrui333 chenrui333 closed this Nov 16, 2023
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Nov 16, 2023
@chenrui333
Copy link
Member

chenrui333 commented Nov 16, 2023

Hi folks, Not sure if this is relevant, but putting it here just the same...

rust-lang/rust#116397

For what is worth, this PR (rust-lang/rust#117875) actually fixed the build issue on 12-arm

@jqnatividad
Copy link
Contributor

With 1.74.0 now out, is the team planning on skipping 1.73.0 and just go directly to 1.74.0?

@ZhongRuoyu
Copy link
Member

With 1.74.0 now out, is the team planning on skipping 1.73.0 and just go directly to 1.74.0?

Yes, we're doing that in #154526.

@chenrui333
Copy link
Member

for folks on this thread, we have just shipped rust 1.74.0

@Bo98 Bo98 removed the help wanted Task(s) needing PRs from the community or maintainers label Nov 19, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
12-arm64 Monterey arm64 is specifically affected bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age superseded PR was replaced by another PR upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants